Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 393133

Summary: support comparison of two review items
Product: z_Archived Reporter: Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component: MylynAssignee: Project Inbox <r4e-triaged>
Status: RESOLVED DUPLICATE QA Contact:
Severity: enhancement    
Priority: P3 CC: lmcbout, sebastien.dubois
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:

Description Alvaro Sanchez-Leon CLA 2012-10-30 08:03:57 EDT
A common development scenario is to add multiple versions of a review item to the same review, in order to refine the actual solution against the same base.

It's desirable to compare two selected review items against each other in order to determine the differences and still be able to write anomalies against the latest version so new anomalies woud be reflected in the latest version of the review item.
Comment 1 Alvaro Sanchez-Leon CLA 2012-10-30 08:14:54 EDT
The solution shall consider all different type of changes within a commit e.g. ADD, DELETE, CHANGED, RENAMED

A possible solution: 

* Determine base and target based on commit dates e.g. latest / right
* The resulting change can be displayed in the compare editor with all involved files included in a diff tree and represented in the structural set of changes, similar to what Gerrit connector does when comparing patchsets
* The latest commit is the initial result which gets it base files updated if the files are also found within the base commit as either CHANGED or RENAMED. 
* Files that are present in the base commit as ADD and DELETE shall not be included in the resulting compare as ADD DELETE on the latest commit represents the final decision of the developer

The above solution is aimed to the comparison of two versions of review items towards the same solution, the results for unrelated changes will result in a copy of the latest commit (for the most part)
Comment 2 Alvaro Sanchez-Leon CLA 2012-10-30 08:20:43 EDT
ideally the mylyn versions bug 376063 shall be implemented first to validate this solution for renamed files
Comment 3 Sebastien Dubois CLA 2013-01-09 14:51:07 EST
*** Bug 393712 has been marked as a duplicate of this bug. ***
Comment 4 Sebastien Dubois CLA 2013-01-09 14:52:21 EST
Duplicate of 390966

*** This bug has been marked as a duplicate of bug 390966 ***