Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 392662

Summary: Bad location error occurs from time to time using the up and down arrow from the reviwe navigator
Product: z_Archived Reporter: Jacques Bouthillier <lmcbout>
Component: MylynAssignee: Project Inbox <r4e-triaged>
Status: CLOSED MOVED QA Contact:
Severity: minor    
Priority: P4 CC: fchouinard, lmcbout, sebastien.dubois
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 399542    

Description Jacques Bouthillier CLA 2012-10-23 11:04:15 EDT 
After navigating through a large review using the up and down arrow from the keyboard and from the review navigator, we suddently get the following bad location.
Hard to reproduce, but in this case , it happen after around 87 files opened in editor

org.eclipse.jface.text.BadLocationException
	at org.eclipse.jface.text.AbstractDocument.addPosition(AbstractDocument.java:355)
	at org.eclipse.jface.text.AbstractDocument.addPosition(AbstractDocument.java:376)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.annotation.content.R4EAnnotationModel.connect(R4EAnnotationModel.java:196)
	at org.eclipse.jface.text.source.AnnotationModel.connect(AnnotationModel.java:520)
	at org.eclipse.mylyn.reviews.frame.ui.annotation.impl.ReviewEditorInputListener.configureViewerAnnotations(ReviewEditorInputListener.java:150)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.annotation.control.R4ECompareEditorInputListener.addAnnotationModel(R4ECompareEditorInputListener.java:69)
	at org.eclipse.mylyn.reviews.frame.ui.annotation.impl.ReviewEditorInputListener.inputDocumentChanged(ReviewEditorInputListener.java:121)
	at org.eclipse.jface.text.TextViewer.fireInputDocumentChanged(TextViewer.java:2894)
	at org.eclipse.jface.text.TextViewer.setDocument(TextViewer.java:2943)
	at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java:642)
	at org.eclipse.jface.text.source.projection.ProjectionViewer.setDocument(ProjectionViewer.java:374)
	at org.eclipse.jface.text.source.SourceViewer.setDocument(SourceViewer.java:576)
	at org.eclipse.compare.contentmergeviewer.TextMergeViewer$ContributorInfo.updateViewerDocument(TextMergeViewer.java:771)
	at org.eclipse.compare.contentmergeviewer.TextMergeViewer$ContributorInfo.internalSetDocument(TextMergeViewer.java:728)
	at org.eclipse.compare.contentmergeviewer.TextMergeViewer$ContributorInfo.setDocument(TextMergeViewer.java:646)
	at org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateContent(TextMergeViewer.java:2831)
	at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.internalRefresh(ContentMergeViewer.java:743)
	at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.inputChanged(ContentMergeViewer.java:643)
	at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:280)
Comment 1 Jacques Bouthillier CLA 2012-11-20 13:48:25 EST 
With R4E 0.12.0, Navigating using the arrow with just a few anomalies from 2 commits and one ressource review item, I get the same bad location. I use a BASIC review, I removed the "Hide DElta" filter
Comment 2 Jacques Bouthillier CLA 2012-11-21 09:19:33 EST 
After switching from JAVA to TEXT and back to JAVA compare view, I noticed that the anomaly navigation arrow changes the selection   in the review navigator view, but nothing gets selected in the compared editor
Comment 3 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn