Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 392114

Summary:

Globals in gitStatusExplorer.js and gitCommitExplorer.js

Product:

[ECD] Orion

Reporter:

John Arthorne <john.arthorne>

Component:

Git

Assignee:

Project Inbox <orion.git-inbox>

Status:

RESOLVED INVALID

QA Contact:

Severity:

normal

Priority:

CC:

Szymon.Brandys

Version:

1.0

Flags:

Szymon.Brandys: review? (ken_walker)

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
DOM inspector screen shot	none

Description John Arthorne

2012-10-16 15:48:57 EDT

Build: 1.0 RC2

These scripts define several global variables (bound to "window" in browser).

gitCommitExplorer.js:
 - DiffModel
 - DiffNavigator
 - DiffRenderer

gitStatusExplorer.js
 - StagedModel
 - StagedNavigator
 - StagedRenderer
 - UnstagedModel
 - UnstagedNavigator
 - UnstagedRenderer

Comment 1 John Arthorne

2012-10-16 15:49:32 EDT

Created attachment 222433 [details]
DOM inspector screen shot

Comment 2 Szymon Brandys

2012-10-17 10:07:00 EDT

https://orion.eclipse.org/git/reviewRequest.html#ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_d965e3d6166b83e22bcd5f3788487a27c6dbeaf9

Ken, could you review?

Comment 3 Szymon Brandys

2015-04-01 10:06:09 EDT

Invalid.