Bugzilla – Full Text Bug Listing
| Summary: | Orion banner is too wide | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> | ||||
| Component: | Client | Assignee: | John Arthorne <john.arthorne> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | antonm, Mike_Wilson, susan | ||||
| Version: | 1.0 | Keywords: | helpwanted | ||||
| Target Milestone: | 2.0 M1 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Looks like ide.css is setting 'min-width: 900px' on the <body>, not sure why. Removing that allows the banner to collapse more nicely... It used to do this in the not too distant past. For screen shots I wouldn't worry about showing everything, just crop down to the parts you are talking about. I definitely remember that the banner used to scale down indefinitely, because we had even discussed different strategies for wrapping the data. I don't recall us ever deciding on a fixed/min page width, and 900px is weird because I would expect to support an iPad in portrait mode (768) with minimally a media query, or at least to choose this if we need a minimum. Out of curiosity, I checked the history and the change is pinned to this commit, so presumably Anton and/or McQ will recall... http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e19cd156ec7d113ca0e90498c575df4d52a586bc Taking this in preparation for m1 screenshots next week. I have changed it to 700px. When I tried removing it entirely, strange things started to happen when the search bar ran up against the page buttons. This compromise at least support (old) iPad portrait mode and will be a bit nicer for screen shots: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d3577620b14cd2bc86f3d7a4d9fcfe7d096e01e7 |
Created attachment 222367 [details] screenshot showing how wide it is While taking some screenshots, I noticed that the Orion banner expects the browser to be approx 900px wide or wider. If you make it any smaller, the banner truncates. I actually had to doctor some of the screenshots to make them fit inside 800px. This is wasteful since there's a lot of empty horizontal space available. The empty space should collapse first.