Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391948

Summary:	Incremental Find doesn't handle Enter correctly
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	P3	CC:	jparks, Silenio_Quarti
Version:	1.0	Keywords:	helpwanted
Target Milestone:	---	Flags:	jparks: review?
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2012-10-15 12:07:46 EDT

1. Open editor on a file
2. Press Ctrl+J and type in a term that appears in the file.
3. The match is highlighted and status line shows:
> Incremental find: var
4. Now press Enter. The incremental find appears to search for an actual newline as part of your search term, and you see:
> Incremental find: var_

This is weird. I expected Enter to cancel incremental find (as in Eclipse desktop). Another acceptable alternative would be for Enter to go to the next match.

Comment 1 Josh Parks

2012-11-20 15:39:31 EST

GitHub URL: https://github.com/jparks06/orion.client.git
Branch: Bug391948
Commit ID: 1f8103504fd1c50b378788ca177daa45939c96ae

Altered the "enter" function for the Incremental Find feature. Now hitting 'enter' cancels out of the search and returns to the regular editor.

Comment 2 Silenio Quarti

2013-10-03 10:31:57 EDT

This has been fixed for a while (Orion 3.0 and greater)