Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391818

Summary: TypeError in console on repositories page
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: GitAssignee: Project Inbox <orion.git-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Szymon.Brandys
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2012-10-12 13:41:36 EDT
I20121011-2230 on orion.eclipse.org. Chrome 22, Windows 7.

1) Clone org.eclipse.orion.client git repository
2) On Repositories page, click on that repository to "go into" that repository
3) On loading this page, I always see several TypeErrors in the console. It doesn't seem to have any negative impact on the page. I even tried deleting my clone and starting fresh and I still see it.

Here is a sample from the Chrome console:

TypeError
arguments: Array[2]
0: "format"
1: undefined
length: 2
__proto__: Array[0]
get message: function () { [native code] }
get stack: function () { [native code] }
set message: function () { [native code] }
set stack: function () { [native code] }
type: "non_object_property_call"
__proto__: Error
 built-git-repository.js:1772
(anonymous function) built-git-repository.js:1772
reject.errback built-git-repository.js:1772
g built-git-repository.js:1771
(anonymous function) built-git-repository.js:1770
f built-git-repository.js:1771
resolve.callback built-git-repository.js:1772
e.followOperation built-git-repository.js:2931
k._operationsClient.getOperation.then.a.hitch.Severity built-git-repository.js:2930
e built-git-repository.js:1875
b built-git-repository.js:1874
resolve built-git-repository.js:1875
o built-git-repository.js:1907
(anonymous function) built-git-repository.js:1915
k
Comment 1 John Arthorne CLA 2012-10-12 13:56:47 EDT
Same error in FireFox 16, but a bit more detail in the log:

TypeError: a.date.locale is undefined
	

...mat(new Date(f.Time),{formatLength:"short"})),e,"last");var h,j=new orion.git.wi...

By setting a breakpoint on the error in FireFox, it looks like line 904 of gitRepositoryExplorer.js. We are just dumping a bunch of data into innerHTML here, so I wonder if it is a particular commit name or author causing the problem.

		var description = dojo.create( "span", { "class":"gitSecondaryDescription",  //$NON-NLS-2$ //$NON-NLS-1$ //$NON-NLS-0$
			innerHTML: messages[" (SHA "] + commit.Name + messages[") by "] + commit.AuthorName 
			+ " on " + dojo.date.locale.format(new Date(commit.Time), {formatLength: "short"})}, detailsView ); //$NON-NLS-1$ //$NON-NLS-0$
Comment 2 John Arthorne CLA 2015-05-05 14:52:48 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html