Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391794

Summary:	mGlobalCommands.getAuthenticationIds function was removed but it's still called
Product:	[ECD] Orion	Reporter:	Malgorzata Janczarska <malgorzata.tomczyk>
Component:	Client	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, simon_kaegi
Version:	1.0	Flags:	simon_kaegi: review+
Target Milestone:	1.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Malgorzata Janczarska

2012-10-12 10:30:13 EDT

mGlobalCommands.getAuthenticationIds was removed in Bug 349395 (6f65b4356d2869abbc595dd6c13dde50fdfa5cc7), but plugin.js and operations/list.js still call this function. There where registered for the change of logged in user, that, as I understand Bug 349395 are not longer generating the localStorage event.
The reason they where notified was that when users logs out or logs in he has the access to a different tasks set (only taks run by the user logged in), so operation site was reloading operations list on user change. Lack of this feature is not perfect, but getting for 1.0 I suppose the best way will be to remove this event tracking to avoid errors.

Comment 1 Malgorzata Janczarska

2012-10-12 10:38:31 EDT

Simon, could you review and push it, if you think the fix is good?
https://orion.eclipse.org/git/reviewRequest.html#ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_f2672dc3fde29c6c28294a3c5ddf90c8dc283311

Comment 2 Simon Kaegi

2012-10-12 11:38:11 EDT

Ah sorry. I missed that somehow. I'll review and push asap.

Comment 3 Ken Walker

2012-10-12 12:17:59 EDT

Both Simon and I tried that Review process but it did not work.  Even after checking out the specific branch that link doesn't do the right thing.  It says the commit cannot be found.

Comment 4 Simon Kaegi

2012-10-12 12:26:44 EDT

Pushed.

I cherry-picked from my log on my self-hosted site to get the working commit/log page but still think there may be an issue for the review. Too bad as this would be incredibly handy right now...