Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391708

Summary:	use of <list> tags in our generated HTML
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Szymon Brandys <Szymon.Brandys>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, malgorzata.tomczyk, mamacdon, Szymon.Brandys
Version:	0.5
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-10-11 14:58:59 EDT

I was reviewing the code for bug 389747 and wondered about our use of <list>.
I double checked the HTML5 spec that this wasn't some new tag I didn't know about, and it's not.

However when I went to change these to <div>, the styling changed.  (Side note, I could change these to <elephant> with the same result).  That seemed odd.  Then I realized that settings.css includes markup for <list> and <grid> tags.

Discussed with Simon a bit.  We don't see why we would be inventing new markup  Since the <list> tag is used pervasively now (plugin list, most git pages), it's not something to change at this time, but requires some discussion about why we are doing this, the benefit, etc.

Comment 1 Szymon Brandys

2012-10-12 03:54:06 EDT

If I recall well, I copied some code from the very first version of plug-ins page (the one made by Anton). <list> tag was there and later during git pages refactoring was never replaced. I will scan all git pages at the beginning of 2.0 and replace that.

Comment 2 Malgorzata Janczarska

2012-10-12 06:31:23 EDT

Just for the record <list> tag is nothing new in HTML and HTML 5 also supports it:
http://woork.blogspot.com/2009/09/html-lists-whats-news-in-html-5.html

Comment 3 Susan McCourt

2012-10-12 11:55:55 EDT

(In reply to comment #2)
> Just for the record <list> tag is nothing new in HTML and HTML 5 also
> supports it:
> http://woork.blogspot.com/2009/09/html-lists-whats-news-in-html-5.html

I understand <ul> <ol> etc., but the code has <list>. Am i missing something?

Comment 4 Malgorzata Janczarska

2012-10-15 04:54:53 EDT

(In reply to comment #3)
> I understand <ul> <ol> etc., but the code has <list>. Am i missing something?
huh... the code now uses divs for items, I suppose it used to use uls or ols inside and that's where did the list tag here come from. I now totally agree that it should be changed to div.

Comment 5 Szymon Brandys

2012-10-15 07:46:22 EDT

In html lists are defined as follows:

<ul>
  <li>Coffee</li>
  <li>Tea</li>
  <li>Milk</li>
</ul> 

<ol>
  <li>Coffee</li>
  <li>Tea</li>
  <li>Milk</li>
</ol>

No <list>. Am I missing something?
And as I recall, there was no <li> elements on this page. It must be just a mistake, see my comment 1.

Comment 6 Mark Macdonald

2012-10-30 17:29:02 EDT

+1 for switching to <elephant>.

Comment 7 Szymon Brandys

2012-12-20 08:29:44 EST

Fix with 51af3dfcc5967a55330775762aa8cd00b52844da