Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391595

Summary:	Initial visit to navigator is missing New Folder command
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Flags:	john.arthorne: review+
Version:	1.0
Target Milestone:	1.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2012-10-10 14:36:23 EDT

1. Create a new account on an Orion server that has user-creation enabled.
2. Log in 
3. The New Folder command is missing from the Navigator
4. Click Refresh in the browser
5. Now the New Folder command appears

Comment 1 Susan McCourt

2012-10-10 16:50:49 EDT

I'll investigate for RC2.  I think that we probably render the toolbar tools before the default workspace gets created...

Comment 2 Susan McCourt

2012-10-12 14:49:43 EDT

It looks like the response from fileImpl when a workspace first gets created is wrong.  I see the get for all workspaces, and the put to create one:

	
GET http://susan.orionhub.org/workspace
200 OK
{
  "Id": "CVX",
  "Name": "00testbug391595",
  "SearchLocation": "/filesearch?q=",
  "UserName": "00testbug391595",
  "Workspaces": []
}

POST http://susan.orionhub.org/workspace
200 OK
{
  "Children": [],
  "ChildrenLocation": "/workspace/00testbug391595",
  "Directory": "true",
  "Id": "00testbug391595",
  "Location": "/workspace/00testbug391595",
  "Name": "MyWorkspace",
  "Projects": [],
  "SearchLocation": "/filesearch?q="
}


However in fileImpl, the _createWorkspace code that returns the response is trying to return response.Workspaces

Comment 3 Susan McCourt

2012-10-12 15:15:04 EDT

Fixed in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=af58d1c05415e14e484a1d3d5e2c9968bb2e50d5

This has probably been wrong for a long time.
Verified that a new user now gets an empty workspace with the toolbar commands expected.

John, can you review?

Comment 4 Susan McCourt

2012-10-12 15:15:41 EDT

To test the fix you have to run orionhub or some other server configured to let you create new accounts.  Then login as the new user.

Comment 5 John Arthorne

2012-10-12 16:35:37 EDT

Simon was making a change in the same file, so we committed it as part of:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bf16b9ec936400647736a45597996f4668f9d7b0