Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391479

Summary:

Git log: No longer be able to press ENTER to view a commit.

Product:

[ECD] Orion

Reporter:

libing wang <libingw>

Component:

Git

Assignee:

libing wang <libingw>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

Szymon.Brandys

Version:

0.5

Flags:

Szymon.Brandys: review+

Target Milestone:

1.0 RC2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Patch for Szymon to review	none

Description libing wang

2012-10-09 16:05:01 EDT

The new git log page uses selection model now.
But when I use up and down arrow keys to select a commit and use ENTER key, it does not bring me to the commit page. It asks me to create a new tag instead.
I think this is because the "commit link" is not in the navigation grid.

Comment 1 libing wang

2012-10-09 16:26:05 EDT

Created attachment 222088 [details]
Patch for Szymon to review

Comment 2 libing wang

2012-10-09 16:33:07 EDT

Szymon, when you render the actions the call of this.getActionsColumn(item, tableRow, null, null, true); put all the commands into nav grid by free. That is why we see all the commands in the grids.
The links at the first column, we have to call mNavUtils.addNavGrid function to let the selection model know that the DOM node is in the grid navigation.
I put the patch for you to review. The change is simple and safe.

Comment 3 libing wang

2012-10-10 13:35:04 EDT

 I've pushed the commit to branch bug391479 and  tried to  ask for review in Orion. Seemed that it does not recognize "Szymon brandys" as the user name. And I have no idea what name I should put there.

Comment 4 Szymon Brandys

2012-10-10 15:36:42 EDT

(In reply to comment #3)
>  I've pushed the commit to branch bug391479 and  tried to  ask for review in
> Orion. Seemed that it does not recognize "Szymon brandys" as the user name.
> And I have no idea what name I should put there.

"sbrandys". You can also just paste the review link to Bugzilla. Anyway, the commit is fine and I merged it to master. Thanks!