Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391465

Summary:	plugin cleanup
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker
Version:	0.5	Flags:	susan: review? (ken_walker)
Target Milestone:	1.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-10-09 13:44:59 EDT

While cleaning up some of my github plugins for 1.0, I found some cosmetic things and some old property values in some of the plugins hosted by orion.  This bug tracks those changes.

toRGBPlugin - move the "work" method to its own function, this will help in blogging to show what has to happen to create a plugin.

pageLinksPlugin - the orion.navigate.content command parameter has a property value of "hidden" which is not supported anywhere anymore.

Comment 1 Susan McCourt

2012-10-09 14:02:53 EDT

pushed in 
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e085ed6fc1f3392c18b21195413551fcc955bddd

I pushed without review thinking, "it's just the RGB plugin which is not in the set of auto-loaded."  but pageLinksPlugin.html is a preloaded plugin and hence is part of Orion.  Adding Ken to review after the fact?....

Comment 2 Ken Walker

2012-10-09 14:13:31 EDT

I looked at the code and it seems fine. Dr. Who review to the rescue