Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391348

Summary: git-log2 needs selection model
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: GitAssignee: Szymon Brandys <Szymon.Brandys>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: malgorzata.tomczyk
Version: 1.0Flags: malgorzata.tomczyk: review+
Target Milestone: 1.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Szymon Brandys CLA 2012-10-08 07:45:55 EDT 
git-log2 needs selection model. It is needed for consistency, but also because there is at least one action that needs selection on this page.
Comment 2 Malgorzata Janczarska CLA 2012-10-08 08:32:31 EDT 
Generally solution looks OK, only small comments to code:

You are not passing selection to logNavigator. Doesn't that mean that selection made in it is not passed anywhere?

Lines 310, 335, 448: if you define a class in the method you should start with var LogModel = ..., alternatively you can define class globally for the log object.

Line 301: avoid names with "2", like displayLog2, especially that there is no displayLog1

Line 453: variable status shouldn't be there
Comment 3 Szymon Brandys CLA 2012-10-08 08:39:52 EDT 
(In reply to comment #2) 
> You are not passing selection to logNavigator. Doesn't that mean that
> selection made in it is not passed anywhere?

It's not consumed anywhere at the moment. I'll do it when fixing bug 386056.

> Lines 310, 335, 448: if you define a class in the method you should start
> with var LogModel = ..., alternatively you can define class globally for the
> log object.

Fixed.
Comment 4 Szymon Brandys CLA 2012-10-08 08:43:23 EDT 
Fixed with 140641bf8c1b8677aec9c890fcf0da259905725f.
Comment 5 Szymon Brandys CLA 2012-10-08 08:44:38 EDT 
Fixed.