Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391155

Summary:	Initial commit of doctrine jsdoc support
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Editor	Assignee:	Project Inbox <orion.editor-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, simon_kaegi
Version:	1.0	Flags:	simon_kaegi: review+ ken_walker: review+
Target Milestone:	1.0 RC3
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Andrew Eisenberg

2012-10-04 15:40:46 EDT

This bug is to track the initial commit of the doctrine library (https://github.com/Constellation/doctrine) into orion.  I have tested this locally and it is working for me.  All tests are still passing.

I created a new branch called 'doctrine-support` that has the changes and pushed to git.eclipse.org.

In addition to the doctrine library, I have a few code cleanups in the content assist files that I made during the integration.  They are safe changes and are mostly about documentation.

Once doctrine support has been pushed to master, I'll close this bug.

Comment 1 Andrew Eisenberg

2012-10-04 15:45:22 EDT

Adding Simon to review this code contribution.

To make sure this is working, add this to an empty js file:

/** @type {{val:string}} */
var kkk;

kkk.val.|

Invoke content assist at the | and you should be getting String proposals.

Also, try this:

/**
 * @param {Number} foo
 * @return {string}
 */
function myFun(foo) {
  foo.
}
myFun().

Inside of the function, you should be getting number-like content assist for foo. And string-like content assist for myFun() outside of the function.

Comment 2 Simon Kaegi

2012-10-11 15:29:54 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?h=doctrine-support&id=c22f30a2790b316abff13b971377c49317f14d21

Looks good. Are you going to re-enable the tests? I'm assuming you are...

For purposes of review I was more checking file layouts etc and looked at the diff  but did not test it directly. I will try it out more rigorously in tomorrows build.

Comment 3 Andrew Eisenberg

2012-10-11 15:47:15 EDT

The tests are set up so that if the doctrine library actually exists, then they run automatically.  So, tests will be automatically enabled when merged with master.

Comment 4 Ken Walker

2012-10-11 17:38:44 EDT

Have looked at this much the same as Simon. Works as advertised.

Please commit for tonights build.

Comment 5 Andrew Eisenberg

2012-10-11 17:55:03 EDT

Thanks for the reviews.  Merged with master.  The doctrine-support branch is now no longer needed.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=76dcc81ad1e80748a037f4ce8346d6bc96d615c5

Comment 6 Andrew Eisenberg

2012-10-11 17:55:27 EDT

Will be in the next nightly build.