Bugzilla – Full Text Bug Listing
| Summary: | IE 9: Large css files are not parsed completely. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Client | Assignee: | libing wang <libingw> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | ken_walker, libingw, Silenio_Quarti | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | 4.0 RC2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
I tried to debug the issue but in my selfhosting(IE9) I could not reproduce the issue. One more thing I found interesting is that even in the unified diff view, the diff annotation classes are not built in the git-status2.css file, which causes diff annotations not rendered at all. All the annotation classes are in the DOM node though. I will see if the new build still have the same issue. IE9 is not parsing the built git-status2.css, I will download a build and run locally and try to modify the css to see. Good catch, Silenio. I tried to reorder all the compare related css classes, in the front of the built git-status2.css file. Everything is working in IE9 now. I also tried to remove the compare-container.css from git-status2.css and link it in the git-status.html file. At least my self-hosting is working. I've pushed a potential fix for both status and commit pages into branch bug391129. http://libingw.orion.eclipse.org:8080/git/reviewRequest.html#ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_66fcdef5632c47fdda4ace192c420d0b37668904 The review URL should be https://orion.eclipse.org/git/reviewRequest.html#ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_66fcdef5632c47fdda4ace192c420d0b37668904. Found this artile but it is talking about number of css files, not the size of a single big file. http://social.msdn.microsoft.com/Forums/en-US/iewebdevelopment/thread/ad1b6e88-bbfa-4cc4-9e95-3889b82a7c1d Another interesting artical: http://john.albin.net/css/ie-stylesheets-not-loading Strong evidences that IE 9 sucks on css file size. Putting to 2.0 as a reminding bug for a generic solution. We may want to resolve this by splitting it into smaller css files? I dunno... Summary of the issue for future reference:
In the minified git-status2.css file from the build, IE9 ignored couple of hundred line after this line
.compareEditorParent {
width:100%;
height: 100%;
overflow: hidden;
}
All the classes that affects the layout of the border container, text view annotation are missing. That is why you do not see :
1. The diff annotations because the annotaion classes are not loaded.
2. The left hand of side by side widget because the css that initialize the DOM node size is missing.
Same thing happens in git commit page. Both of them have minified css size around 355k.(Some articles say the limit is 288k)
All the related classes were loaded properly in compare.html because the compare.css is 160k.
I've changed the abstract to "IE 9: Large css files are not parsed completely" as it is a generic IE 9 issue rather than compare widget.
Just tried IE10 today. Seems the css limit is gone and all the css classes were parsed. Will keep an eye on the formal realse of IE10 in M2. The preview one works for the large css though. Libing this can probably be closed. I've verified that it's fine in IE10, and IE9 is no longer supported. thanks, Grant. |
Created attachment 221906 [details] screenshot - observed with IE9 - I made a one-line change to a comment, went to the Git Status page, and viewed the change side-by-side - however the left side of the side-by-side compare is not shown, see the attached screenshot (the comment change I made was in line 106, which is why the screenshot has a horizontal line there, trying to map it to the old line 106)