Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391125

Summary: signing out does not return to login screen (IE only)
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: ClientAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi
Version: 1.0   
Target Milestone: 1.0 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Grant Gayed CLA 2012-10-04 10:30:58 EDT 
- using IE9

Signing out on IE appears to still have the old sign out behaviour, which leaves you on the current page rather than sending you back to the login screen.
Comment 1 Grant Gayed CLA 2012-10-04 12:51:19 EDT 
The loop at UserMenu:67 has two problems:

1. It increments from 0 to localStorage.length, but any time line 70 is hit (localStorage.removeItem(name)), the items following the removed items all have their indices decremented by 1, so the item immediately following the removed item never gets considered in the loop.  This is happening in all browser types.

2. It initializes "length" up-front, but every encounter with line 70 decrements what this value should be by 1.  So on all browsers the last few calls to localStorage.key(i) (line 68) are out of bounds.  The difference is that non-IE browsers just return null in this case, but IE errors instead, which is why the auto-navigation to the login page is not happening there.

Fixed > 20121004, patch: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a67864a46b07b1e6891cc217e26893d329363efb