Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 391041

Summary: Editor probably needs a destroy method
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: EditorAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 1.0   
Target Milestone: 2.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2012-10-03 12:05:42 EDT
When an Editor needs to be destroyed, you're forced to call ditor.getTextView().destroy(). This is strange. The Editor should have its own destroy() that cleans up the TextView for you. We also need to investigate whether editor allocates resources (aside from the TextView) that should be freed.
Comment 1 Silenio Quarti CLA 2012-11-08 13:41:44 EST
Added destroy() and uninstallTextView() APIs.  After destroy is called the editor instance should not be used any more. The uninstallTextView() API was added to be symmetrical to installTextView() API. It sends TextViewUninstalled event.  The editor text view can be installed/uninstalled multiple times.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2733cd6fed8629b9cc1a578e53992edba6da1478