Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 390850

Summary: NLS Tool and Search+Replace does not update the target text editor with new state
Product: [ECD] Orion Reporter: Ken Walker <ken_walker>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: malgorzata.tomczyk, Silenio_Quarti
Version: 0.5Flags: Silenio_Quarti: review+
Target Milestone: 1.0 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch for Silenio to review none

Description Ken Walker CLA 2012-10-01 12:53:55 EDT 
If you install the NLS Plugin, choose a directory and Xternalize it the behaviour has changed.  As you are checking off items that should not be externalized, the text in the right hand side representing the state of the unsaved changes should be updating and showing either messages[] or NON-NLS, but it does not ever change anymore.  

Likely the hook for updates is not longer happening?
Comment 1 Malgorzata Janczarska CLA 2012-10-10 10:56:15 EDT 
This looks like a problem in compare editor. Same problem can be found in Search+Replace screen when checking/unchecking changes. To reproduce you need to check/unckeck changes few times, first time usually works.

After some debugging I found this problem when calling twoWayCompareContainer.setEditor();

TypeError: view is null

var viewModel = view.getModel();

textStyler.js (line 1068)
Comment 2 libing wang CLA 2012-10-10 13:40:00 EDT 
Created attachment 222135 [details]
patch for Silenio to review
Comment 3 libing wang CLA 2012-10-10 13:41:06 EDT 
Hi, Silenio, it seemed that only with your changes, the issue is gone. So I do not have to do anything additionally. Could you just double check the changes?
Comment 4 Silenio Quarti CLA 2012-10-10 15:02:01 EDT 
Changes are good.
Comment 6 Malgorzata Janczarska CLA 2012-10-11 07:01:30 EDT 
I verified the fix and compare editor is now correctly refreshed. However there is a problem with change marks in the right side editor, I opened Bug 391650 for that.