Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 390721

Summary: The product IU qualifier is not updated
Product: [Technology] CBI Reporter: Paul Webster <pwebster>
Component: prototypeAssignee: CBI Dummy user <cbi.prototype-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: igor, jan.sievers, t-oberlies, thanh.ha
Version: 1.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 392716    
Bug Blocks: 372792    
Attachments:
Description Flags
product patch
none
product patch v2 none

Description Paul Webster CLA 2012-09-28 13:46:55 EDT 
Features that the product IU depends on change, but the product IU is not updated.  That would prevent updating from the current build to the new build, even though there are new feature contents.

In PDE build the product IU takes on the buildTag, I20120908-2000 or M20120909-1200.

PW
Comment 1 Tobias Oberlies CLA 2012-11-15 09:42:36 EST 
You can override the automatically computed qualifier by setting the parameter forceContextQualifier on the tycho-packaging-plugin.

This is not as nice as an automatically computed qualifier based on the included products (requiring Tycho bug 392716), but it should be good as an intermediate solution.
Comment 3 Jan Sievers CLA 2012-11-15 10:34:48 EST 
hmm... probably have to disable the  jgit buildtimestamp provider and use the default instead (just for the product module).

Maybe something like

     <plugin>
        <groupId>org.eclipse.tycho</groupId>
        <artifactId>tycho-packaging-plugin</artifactId>
        <version>${tycho-version}</version>
        <configuration>
          <timestampProvider>default</timestampProvider>
        </configuration>
     </plugin>
Comment 4 Thanh Ha CLA 2012-11-16 14:05:11 EST 
(In reply to comment #3)
> hmm... probably have to disable the  jgit buildtimestamp provider and use
> the default instead (just for the product module).
> 
> Maybe something like
> 
>      <plugin>
>         <groupId>org.eclipse.tycho</groupId>
>         <artifactId>tycho-packaging-plugin</artifactId>
>         <version>${tycho-version}</version>
>         <configuration>
>           <timestampProvider>default</timestampProvider>
>         </configuration>
>      </plugin>

Do we need the forceContextQualifier in addition to this or is just this is enough?
Comment 5 Tobias Oberlies CLA 2012-11-19 07:03:03 EST 
No, just re-enabling the default timestampProvider should be enough.
Comment 6 Thanh Ha CLA 2012-11-19 12:53:39 EST 
Created attachment 223723 [details]
product patch

Attached patch adds Jan's suggestion to the product pom files.
Comment 7 Thanh Ha CLA 2012-11-26 14:18:05 EST 
Created attachment 223963 [details]
product patch v2

I discussed with Paul this morning and we decided since buildId is being used to override the build qualifier in many parts of the build we should be using it to override here as well.

With this new patch we use "<format>'${buildId}</format>" to override the qualifier instead of calling the timestamp. ${buildId} is defined in eclipse-parent/pom.xml and can be overridden by passing -DbuildId=somebuildid on the commandline.
Comment 8 Paul Webster CLA 2012-11-26 19:54:00 EST 
(In reply to comment #7)
> Created attachment 223963 [details]
> product patch v2

I've released this to 4.2.2, and started a test build

PW