Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 390481

Summary: clean shortcut does not work in editor window
Product: [Eclipse Project] Platform Reporter: Ari Fogel <ari>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: CLOSED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: michael.wohlfart, pwebster
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Ari Fogel CLA 2012-09-26 15:36:53 EDT 
Similar to a recently fixed bug causing a 'build project' keyboard shortcut not to work in any editor ( https://bugs.eclipse.org/bugs/show_bug.cgi?id=383497 ), a 'Clean...' keyboard shortcut will also not work in an editor window. This buggy behavior appears to be new to Juno, like the referenced bug. I believe that this bug can be patched in a way similar to the referenced bug, but I do not personally have the time/familiarity with the eclipse source to do this myself.

Expected behavior: Pressing shortcut for 'Clean...' while in editor window opens window asking which projects you would like to clean, defaulting to only the project linked to the currently opened file in the editor

Actual behavior: Pressing shortcut for 'Clean...' while in editor window does nothing at all.

Using Eclipse Juno CDT amd64 for linux.
Comment 1 Michael Wohlfart CLA 2012-10-07 12:42:02 EDT 
I just had a look at this and I am having trouble repoducing...

I downloaded Juno SR1 CPP, created a new cpp project and added some files. After assigning a key binding to 'Build Clean' and unchecking 'Build automatically', I tried the binding in the context of a cpp editor -> The Clean window came up.

Is there any hint you can give me to reproduce the bug?

----

Version Info:
Eclipse IDE for C/C++ Developers
Version: Juno Service Release 1
Build id: 20120920-0800
Platform: win32
Comment 2 Ari Fogel CLA 2012-10-08 16:03:42 EDT 
I tried your exact procedure, and no clean window comes up. I am using Juro SR1 CPP for Linux, 64-bit.
Comment 3 Ari Fogel CLA 2012-10-08 16:04:38 EDT 
As a matter of fact, no shortcut even appears on the project menu for clean... after binding a key for clean project
Comment 4 Michael Wohlfart CLA 2012-10-08 17:47:14 EDT 
I just tried it on my linux 32-bit vm. After assigning a key binding to 'Build clean' and choosing when 'In Dialogs and Windows' the key binding shows in the main menu. The shortcut works while in a c editor.

I currently have no 64bit linux machine here, but this bug being related to the architecture used seems a little awkward to me. This should be plain UI code...
Comment 5 Ari Fogel CLA 2012-10-08 18:08:05 EDT 
It appears that the bug is related to my specific choice of keyboard shortcut. I chose CTRL+SHIFT+C, which is also used by comment. This conflict is not shown in the Keys tab of Preferences. However, until I unbound the shortcut for comment, the shortcut for clean did not appear on the projects window, nor did it work when the combination was pressed.
So it appears this bug is invalid, but there is another bug where not all keybinding conflicts are shown appropriately in the Keys tab in Preferences. Note that for my test, I had Clean... set to Shift+Control+C when in windows and dialogs, while comment was Shift+Control+C when editing text.
Comment 6 Paul Webster CLA 2012-10-10 10:50:03 EDT 
(In reply to comment #5)
> So it appears this bug is invalid, but there is another bug where not all
> keybinding conflicts are shown appropriately in the Keys tab in Preferences.
> Note that for my test, I had Clean... set to Shift+Control+C when in windows
> and dialogs, while comment was Shift+Control+C when editing text.

I think that there shouldn't have been a conflict between the 2 different contexts (text should simply override dialogsAndWindows when the text context is active)

PW