Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 390480

Summary: Slow performance on folder requests
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: ServerAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: pedemont, simon_kaegi
Version: unspecified   
Target Milestone: 1.0 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2012-09-26 15:29:27 EDT
1.0 M2

Simon is noting slow requests for folder listings. I am seeing ~500ms for a folder metadata request, which is pretty slow. Simon is seeing 3+ seconds. Need to profile and see what is happening.
Comment 1 John Arthorne CLA 2012-09-27 17:13:50 EDT
I made optimizations to several hotspots and it is much faster now. Most of the changes were pulling up git computations out of the loop over children, so we only perform them once per request. The bad case before was folders in git repositories with large numbers of children, because we were repeating many of the same git repository computations for each child.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=c01e9be90ab94ac49a951e553755a62faf509ff4
Comment 2 Simon Kaegi CLA 2012-09-27 22:29:23 EDT
That's great. We're going to feel an immediate speed boost tomorrow...
Comment 3 John Arthorne CLA 2012-11-09 10:43:45 EST
I have backported the non-git parts of this fix to the 0.5 stream to help the Maquetta project. The commit is:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?h=johna/deadlock-workaround-dot5&id=1e8a022cb93c9c4992d3c6db64385e87e162a492

I have also created an annotated tag v20121109-bug390480 for this fix:

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/tag/?id=v20121109-bug390480