Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 390040

Summary:	Need key binding to toggle editor wrap mode.
Product:	[ECD] Orion	Reporter:	Silenio Quarti <Silenio_Quarti>
Component:	Editor	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Silenio Quarti

2012-09-20 13:12:08 EDT

Now that the editor supports wrapping, we need a easy way to toggle it on and off in Orion.

I believe not all users of the editor want the key binding for free.  I think TextView show have an action toggleWrapMode (similar to toggleTabMode), but it should not be associated to a key binding by default.  Users of the editor should associated the key.  So coding.html would add the key biding but compare.html would not, for example.

I am not sure what the key binding would. Is Ctrl+W (Cmd+W) still unused?

Comment 1 Silenio Quarti

2012-09-20 13:26:37 EDT

Ctrl+W is used by the browser to close the tab.

Comment 2 Silenio Quarti

2012-09-20 14:21:07 EDT

Released first part of fix (action in TextView).

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=78dcc03b66d23380492558da8802127f3fe4d3cd

Comment 3 Silenio Quarti

2012-09-20 16:24:06 EDT

Some editors use Ctrl+Alt+W (Cmd+Alt+W on Mac) and this does not seem to conflict with user agents key bindings.

Fixed
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=92114d70a6f04f76ee058982dac8846aa99f43b3