Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389950

Summary:	Editor Find actions not working
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	libingw, susan
Version:	1.0
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2012-09-19 16:56:19 EDT

Ctrl+F in the editor does not open the Find toolbar. Also Incremental Find (Ctrl+J) is not working.

This happens with the latest code from HEAD (most recent commit is 03ab15dc9027d9fd98bdaa8b8a23df7c7f93404b).

Comment 1 libing wang

2012-09-19 17:20:02 EDT

it was because the fillFunction from the parammeterCollector requires a return value now.
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0c7bffa82feb9e6da02dcbef65ee9e1d51bc0ef9.

Comment 2 Susan McCourt

2012-09-20 10:47:09 EDT

(In reply to comment #1)
> it was because the fillFunction from the parammeterCollector requires a
> return value now.
> fixed with
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=0c7bffa82feb9e6da02dcbef65ee9e1d51bc0ef9.

sorry Libing.  I believe there's always been a return value but I made some changes to actually honor the return value, which would have busted you.