Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389927

Summary:	Content assist should also propose non-inferred suggestions
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Editor	Assignee:	Project Inbox <orion.editor-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.5
Target Milestone:	0.5 M2
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Andrew Eisenberg

2012-09-19 14:05:32 EDT

One of the problems with using type inference to perform content assist is that because JS is so dynamic, there are things that can never be completely inferenced.  It would be nice if content assist could also be more liberal in what it returns.

For example, the esprima-based content assist plugin can provide all of its inferred proposals at the of the list, and then include all other identifiers at the bottom of the proposals list as non-inferred proposals.

And, we can take advantage of Bug 389212 to provide styling for the different kinds of proposals so that they look different and users can have a better idea of where these proposals came from.

Comment 1 Andrew Eisenberg

2012-09-19 16:26:57 EDT

Pushed a fix, here: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=aa9a0e969ffecd44f58b2595623b5b010f7006a1

I am reasonably happy with this, but also a little concerned that this will negatively impact performance on large files.

All non-inferred proposals have the noemphasis style chosen.

Currently, the non-inferred proposals only shows identifiers that are actually defined in the current file.  So, globals and browser variables are not shown.  String functions are not shown, etc.

Does this work for you?  Does it make sense?  Do you want the visual style changed?

I am resolving this issue since the basics are now available, but feel free to comment more or raise a new issue.