Bug 389751

Comment 1 John Arthorne 2012-09-17 14:44:05 EDT

Created attachment 221166 [details]
Fix from Thanh

Comment 2 John Arthorne 2012-09-17 15:29:38 EDT

Pushed to master:

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=76bbcaa10f18d720f55cddcc9b983d0e995782c2

And Juno maintenance:

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?h=R3_8_maintenance&id=37290948acd98fa22d439d206b54df214f45c341

Comment 3 Thomas Watson 2012-09-18 01:52:13 EDT

I still don't understand this.  For anything that used to have a source version 1.3 and target < 1.3 now needs to be compiled with 1.5 with jsr14?  This code in no way uses Java 5 constructs.

Comment 4 Thanh Ha 2012-09-18 09:14:35 EDT

(In reply to comment #3)
> I still don't understand this.  For anything that used to have a source
> version 1.3 and target < 1.3 now needs to be compiled with 1.5 with jsr14? 
> This code in no way uses Java 5 constructs.

I'm not sure why but without this modification when I try to build I get the build error below. Although Paul was able to successfully build the 2 bundles using BREE libs. This error seems to only occur when building without using BREE libs so this change adds a profile that is disabled by default and can be activated when the user does not want to use BREE libs in their build.


[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:0.16.0-SNAPSHOT:compile (default-compile) on project org.eclipse.equinox.io: Compilation failure: Compilation failure:
[ERROR] /home/user/Downloads/eclipse2/eclipse.platform.releng.aggregator/rt.equinox.bundles/bundles/org.eclipse.equinox.io/src/org/eclipse/equinox/internal/io/impl/PrivilegedRunner.java:[123,0]
[ERROR] return (context != null)
[ERROR] //
[ERROR] ? AccessController.doPrivileged(runner, (AccessControlContext) context)
[ERROR] : AccessController.doPrivileged(runner);
[ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] Incompatible conditional operand types T and T
[ERROR] 1 problem (1 error)=

Comment 5 John Arthorne 2012-09-18 09:30:08 EDT

The use case is running the Tycho platform build on a personal computer, where you don't have BREE configurations available. In this case I suspect there is no 1.3 VM to compile against?

Comment 6 Paul Webster 2012-09-18 13:48:25 EDT

I wouldn't think so.  I mean, without the bree-libs set it's just using the compiler settings, and I would think if source=1.3 target=1.1 is good enough inside eclipse it should compile outside of eclipse.

Unless trying to build this plugin in an eclipse with only a 1.7 JRE installed causes the same compile error.

PW