Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389724

Summary: Eclipse-SourceReferences missing
Product: [Technology] CBI Reporter: Paul Webster <pwebster>
Component: prototypeAssignee: CBI Dummy user <cbi.prototype-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: igor, robin, thanh.ha
Version: 1.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 380872, 391977, 391978, 391979, 391980, 391981, 391982, 391983, 391984, 391987, 391988, 391989, 391991, 391993, 391994, 391995, 391996, 391997, 391998, 391999, 392000, 392001, 392002, 392005, 392398, 402802    
Bug Blocks: 372792    
Attachments:
Description Flags
eclipse-parent.patch none

Description Paul Webster CLA 2012-09-17 09:49:18 EDT 
Our bundles are missing the Eclipse-SourceReferences headers.  ex, org.eclipse.ui.workbench_3.103.1.v20120906-120042.jar has

Eclipse-SourceReferences: scm:git:git://git.eclipse.org/gitroot/platfo
 rm/eclipse.platform.ui.git;path="bundles/org.eclipse.ui.workbench";ta
 g=v20120906-120042

PW
Comment 1 Paul Webster CLA 2012-09-18 11:09:14 EDT 
Apparently maven has an SCM element, and some level of compatibility was considered when defining our Eclipse-SourceReferences

PW
Comment 2 Thanh Ha CLA 2012-10-15 14:56:00 EDT 
Created attachment 222337 [details]
eclipse-parent.patch

Attached patch enables Tycho to build Eclipse-SourceReferences. This shouldn't be merged into the aggregator repo until all submodules / repos have their repo-specific URLs set for ${tycho.scmUrl} otherwise the build will fail.
Comment 3 Thanh Ha CLA 2012-10-18 16:24:11 EDT 
Pushed the patch into R4_2_maintenance branch. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?h=R4_2_maintenance&id=5bbb8b193691eea7a667eab1f2b307d537e4e13c


Still need to push into R3_8_maintenance.
Comment 4 Thanh Ha CLA 2012-10-18 19:32:53 EDT 
I tested the patch with R3_8_maintenance and it works but I'm holding off committing until Bug 392398 is resolved so that the build doesn't fail due to mismatched version.
Comment 5 Thanh Ha CLA 2012-10-18 20:43:59 EDT 
(In reply to comment #4)
> I tested the patch with R3_8_maintenance and it works but I'm holding off
> committing until Bug 392398 is resolved so that the build doesn't fail due
> to mismatched version.

Committed: 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=89abf58cc23887d1901342f3a132d9e5fe6f99d9
Comment 6 Robin Stocker CLA 2013-11-16 08:47:48 EST 
On EclipseCon Europe, it was brought up that using "git:" URIs (Git protocol) is a problem for corporate environments where everything except HTTP is blocked.

So, for example instead of this URI:

  git://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git

It would be better if this was used:

  http://git.eclipse.org/gitroot/platform/eclipse.platform.ui.git

Thanh, as you have coordinated this, should I open a new bug report or do you want to reopen?
Comment 7 Paul Webster CLA 2013-11-18 09:14:54 EST 
See Bug 421321

PW