Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389428

Summary: selection model doesn't show dotted cursored (focus) emphasis when a grid is not used
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 0.5   
Target Milestone: 1.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Susan McCourt CLA 2012-09-12 12:30:59 EDT
I've just started using explorers in the Directory Prompter dialog.  I was playing around with whether a "nav grid" should be used or not.  When I set up a nav grid, I had focus emphasis and could use the grid keys, etc., but I couldn't click on the name of the folder in the prompter to select it.  This is because in grid mode, the dom node in the grid has its own click behavior and you have to click around the white space.

After talking to Libing, we concluded there is on reason to have a grid in a simple list that doesn't have links or other "actionable" items in the list.  So I removed the nav grid.  This gives me (mostly) the behavior that I want, except there is no focus emphasis (dotted line) on the explorer when you first open the dialog.  The blue is there, but not the dotted line.  I think the dotted line should show up for the whole row so that the user can tell where the focus is in the dialog.
Comment 1 libing wang CLA 2012-09-13 11:27:42 EDT
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bf0ee972ceef644361a0a9accde99e1f38d06486.

The only thing I don,t like is that the outline on a row does not fit the row's border well.
Comment 2 Susan McCourt CLA 2012-09-13 14:58:06 EDT
Libing, this doesn't seem fixed to me.
On Chrome, I see the dotted line when I open the dialog, but it doesn't follow the cursor key as I would expect, it just stays on the root
Comment 3 Susan McCourt CLA 2012-09-13 15:24:09 EDT
(In reply to comment #2)
> Libing, this doesn't seem fixed to me.
> On Chrome, I see the dotted line when I open the dialog, but it doesn't
> follow the cursor key as I would expect, it just stays on the root

It's working on Firefox.  Weird.  My Chrome is 21.0.1180.89 m
Comment 4 Susan McCourt CLA 2012-09-13 15:44:57 EDT
Just tried on chrome on my mac.  Same problem.
I suspect it's a chrome problem that's cleared up in the beta channel, because Mark and Libing don't see this on Chrome 22
Comment 5 Susan McCourt CLA 2012-09-13 15:54:13 EDT
Indeed.  This is a chrome bug that's still in 21, fixed in the beta channel.

http://code.google.com/p/chromium/issues/detail?id=127752
Comment 6 Susan McCourt CLA 2012-09-13 15:54:42 EDT
marking fixed (again).