Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389073

Summary:	Pull gives me an auth fail error without prompting for credentials
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Git	Assignee:	Simon Kaegi <simon_kaegi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	maciej.bendkowski, simon_kaegi
Version:	0.5
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-09-07 13:10:47 EDT

With the latest changes in git credentials (today's build), choosing "Pull" from a repository page always fails.  I get "auth fail" but am never prompted for my credentials.  I instead have to fetch/merge from git log, which still prompts me.

Comment 1 Maciej Bendkowski

2012-09-10 10:46:05 EDT

I think it's connected to bug 389061. There is a bug in the gitCredentialsDialog and therefore I can't be rendered. Probably you get the authentication failure, because of that. On my local build (based on latest master after Simon fixed that bug) there is no problem to pull. Please could you check this bug on your local server? If it's still a problem, please provide a preview of your local storage. Otherwise, you can close.

Comment 2 Susan McCourt

2012-09-10 12:32:40 EDT

It's not working on orion.eclipse.org (20120909) which has the fix for bug 389061.  Before that bug was fixed, you couldn't even load the repo page at all.  now the page loads but I get auth fail for pull.  For fetch (which uses the slideout), it succeeds, so I agree it's probably something to do with that dialog.

Which key(s) are you interested in localstorage?

Comment 3 Simon Kaegi

2012-09-10 13:23:40 EDT

Susan, I had to submit a new fix earlier on today so the fix Maciej is talking about is not fixed on orion.eclipse.org yet. FWIW I fetch/merge on the Git Status page so its something particular to the pull operation or perhaps to the repository page. After you fetch/merge can you pull on the repo page when you self-host?

Comment 4 Maciej Bendkowski

2012-09-11 03:43:25 EDT

(In reply to comment #3)
> After you fetch/merge can you pull on the
> repo page when you self-host?

Please try to reproduce on the self-hosting version. With the fix from Simon I'm almost sure it will work properly.

Comment 5 Maciej Bendkowski

2012-09-11 09:36:17 EDT

It seems we were right. On the today's build I20120910-2230 the problem does not occur anymore. Please check it Susan and close the bug if you can't reproduce.

Comment 6 Susan McCourt

2012-09-12 11:27:15 EDT

yes, it's fixed now.