Bugzilla – Full Text Bug Listing
| Summary: | Settings page won't load | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> | ||||
| Component: | Client | Assignee: | Simon Kaegi <simon_kaegi> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | maciej.bendkowski | ||||
| Version: | 1.0 | ||||||
| Target Milestone: | 1.0 M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Fixed. I've also modified GitCredentialStorage to just return the constructor instead of returning a module. It makes use much more elegant. Also... I noticed we've put a dependency on the user settings page on a git module. This is not allowed because we might have installations that do not include git support. We should use the plugin settings mechanism to contribute the setting instead. See bug 389067 (In reply to comment #1) > Also... I noticed we've put a dependency on the user settings page on a git > module. This is not allowed because we might have installations that do not > include git support. We should use the plugin settings mechanism to > contribute the setting instead. See bug 389067 The git credentials storage is going to be incorporated in the user preference service (see bug 389041). This way there will be no explicit dependency on a git module. The UI and logic might be contributed with a plugin as Simon suggested. Created attachment 220887 [details]
Patch
Patch
Simon missed a line while fixing so the gitCredentialsDialog won't work. Please see my patch for this. Thanks Maciej. |
1. Go to orion.eclipse.org 2. Load the Settings page 3. You get a 404: > https://orion.eclipse.org/orion/git/GitCredentialsStorage.js It looks like the file is actually called 'gitCredentialsStorage.js' (lowercase g). This will fail on case sensitive filesystems (os x, linux) but appears to work on Windows.