Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389057

Summary: [settings] clicking a category causes duplicated UI work
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Mark Macdonald <mamacdon>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kobrigo, libingw
Version: 1.0Keywords: helpwanted
Target Milestone: 2.0 M2Flags: libingw: review+
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Mark Macdonald CLA 2012-09-07 10:28:13 EDT
1. Go to the Settings page
2. In your debug tools put a breakpoint inside
> function ThemeBuilder()
in ThemeBuilder.js
3. Click the "Themes" category.

You'll see the breakpoint is hit twice:
  i. From an onclick handler for the category. It creates the widgets on the right-hand side and causes the hash to be updated to '#category=themeBuilder'.

 ii. From a processHash() handler that runs in response to the hash change. It thinks you want to go to the themeBuilder category, so it destroys all the widgets we just created and creates them again.

The processHash() thing should just bail out if the category's already been selected.
Comment 1 Eyal Kobrigo CLA 2012-12-19 10:27:40 EST
I am looking into it.
Comment 2 Eyal Kobrigo CLA 2012-12-20 08:54:34 EST
Fixed the bug here are the details:
My GitHub: https://github.com/kobrigo/orion.client.git
Branch containing the fix:bug389057
The commit id:2a73623feda3d77e1141b523c5431bc5fe8a3f46