Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 389020

Summary:	Transparent Composite background color in default theme
Product:	[RT] RAP	Reporter:	Ralf Sternberg <rsternberg>
Component:	RWT	Assignee:	Project Inbox <rap-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	ronald.so, tbuschto
Version:	2.0	Flags:	tbuschto: review?
Target Milestone:	2.0 M2
Hardware:	PC
OS:	Linux
Whiteboard:	sr151

Description Ralf Sternberg

2012-09-07 03:49:00 EDT

I've noticed that the background color of Composites is set to transparent in the default theme. This is incompatible with SWT where a Composite has a default background color. A Composite should only inherit its parent's bg color if its background mode is changed.

Comment 1 Ralf Sternberg

2012-09-07 03:59:31 EDT

Caused by commit 4f199bebcd3bd2b7b39eb76b52163bb3fbd8b2fd. It should also be fixed in the 1.5 branch.

Comment 2 Tim Buschtoens

2012-09-07 05:26:14 EDT

There are more. Those are all controls that i could find that have been changed to have a transparent backgrounds:

Commit cea9aa4c04f9d70ea69bd08e76b486b09309e9ca
Ralf Sternberg <rsternberg@eclipsesource.com> on 29.02.12 19:08
Applied Examples demo changes from Nick

Label {
  background-color: #ffffff; => background-color: transparent;
}

Commit 4f199bebcd3bd2b7b39eb76b52163bb3fbd8b2fd
Tim Buschtöns <tbuschto@eclipsesource.com> on 27.03.12 14:40
minor theming adjustments

Composite {
  background-color: #ffffff; => background-color: transparent;
}

Scale {
  background-color: white; => background-color: transparent;
}

Commit 35d3b4fe2fc3aaac43f89d24104bd6d23fb25d04
Ivan Furnadjiev <ivan@eclipsesource.com> on 04.05.12 11:54
Applied Nick's theming patch.

Button[ARROW]:disabled,
Button[PUSH]:disabled,
Button[TOGGLE]:disabled,
Button[TOGGLE]:selected:disabled {
  background-color: #fafafa; => background-color: transparent;
}

Comment 3 Tim Buschtoens

2012-09-07 06:13:26 EDT

Fixed in master with commit 01f310dd69c994c6439a3bfa6088611172758851.

At least one minor adjustment in the examples demo was necessary as a result of the changes. It could break other applications in theory, but i don't think we relied on transparent theming backgrounds anywhere else.

Comment 4 Ralf Sternberg

2012-09-07 06:17:47 EDT

+1 for backporting to 1.5

Comment 5 Ivan Furnadjiev

2012-09-07 08:08:29 EDT

+1 for backporting to 1.5

Comment 6 Ivan Furnadjiev

2012-09-07 12:07:33 EDT

Backport the fix to 1.5 maintenance branch with commit ac917d7346c330697d8625350a8ec2b6bd09e4ce.