Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388754

Summary:	'Open in new tab' option affects Repositories link in the Navigator
Product:	[ECD] Orion	Reporter:	Maciej Bendkowski <maciej.bendkowski>
Component:	Client	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, mamacdon
Version:	unspecified
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Maciej Bendkowski

2012-09-04 10:57:35 EDT

Go to settings and enable the 'open in new tab' option in the Plugin Settings section. Go to the Navigator and click on the 'Repositories' link. It will open in a new tab. On each other page it will open in the same tab. Seems to have a quick fix, but it's quite irritating. Anton, could you take a look at this?

Comment 1 Mark Macdonald

2012-09-06 09:23:25 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f3d365e58254a01ea25e9f6757182d945ca08164

While fixing bug 388385, I missed one place (globalCommands.js) that relied on the old pref value. The reason the Navigator (but not other pages) got the expected "new tab" behavior was because explorer-table processed every link on the page. The same work is now done by globalCommands instead, so I removed that code from explorer-table.

The behavior should be consistent now on all the pages...