Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388697

Summary: change visibility of member in DirectEditManager
Product: [Tools] GEF Reporter: Andreas Muelder <Andreas.Muelder>
Component: GEF-Legacy GEF (MVC)Assignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nyssen
Version: 3.8   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Andreas Muelder CLA 2012-09-03 11:01:32 EDT 
Subclasses may want to enlarge the cell editor frame to display additional information beside the direct edit control., i.e. a org.eclipse.jface.fieldassist.ControlDecoration.

Therefore, the visibility of org.eclipse.gef.tools.DirectEditManager#getCellEditorFrame() and org.eclipse.gef.tools.DirectEditManager#BORDER_FRAME should be protected.
Comment 1 Alexander Nyßen CLA 2012-10-02 07:59:30 EDT 
Enhanced DirectEditManager for extensibility by performing the following changes:
- Changed visibility of DirectEditBorder to protected.
- Changed visibility of getCellEditorFrame() to protected.
- Renamed placeBorder() into placeCellEditorFrame() for better
consistency.

Changes pushed to master (3.9.0M3). Resolving as fixed.
Comment 2 Andreas Muelder CLA 2013-06-05 08:24:54 EDT 
The default constructor of DirectEditManagers inner class DirectEditBorder is not visible to the outside, a public constructor should be added.
Comment 3 Alexander Nyßen CLA 2013-09-30 14:53:00 EDT 
Can you please describe your use case in more detail? 

The cell editor frame you want to manipulate is now accessible to subclasses via getCellEditorFrame(). If you need to access the DirectEditBorder you can do the following:

protected IFigure getCellEditorFrame() {
  IFigure frame = super.getCellEditorFrame();
  DirectEditBorder border = (DirectEditBorder) frame.getBorder();
  // do something with border
  return frame;
}

Why do you need to construct a DirectEditBorder yourself?
Comment 4 Alexander Nyßen CLA 2013-10-17 09:44:23 EDT 
Unset target milestone as the specified one is already passed.
Comment 5 Alexander Nyßen CLA 2014-10-20 09:02:27 EDT 
Resolving as fixed, because of comment #3. Please re-open if there are any objections.