Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388540

Summary:	Non editable stp files
Product:	[Tools] Linux Tools	Reporter:	Alexander Kurtakov <akurtakov>
Component:	Systemtap	Assignee:	Sami Wagiaalla <swagiaal>
Status:	CLOSED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	anithra, obusatto, pmuldoon, swagiaal
Version:	unspecified
Target Milestone:	2.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Alexander Kurtakov

2012-08-31 10:20:12 EDT

If you open a random stp file it can't be edited(no keyboard input) but double clicking on probe alias works.

Comment 1 Sami Wagiaalla

2012-08-31 10:22:16 EDT

Also, saving the file makes the * go away but the file is not modified on disk

Comment 2 Otavio Pontes

2012-09-10 09:25:15 EDT

The stp editor is really weird. It seems that the behavior of opening a file using the menu is not the same of the behavior of opening a file using the toolbar icon.
Using the toolbar icon works for me and using the menu don't. I never tried to open a stp file from a project. Not sure if it will work. How did you open it?

Comment 3 Sami Wagiaalla

2012-10-01 09:54:19 EDT

I am looking into this. Trying to figure out why different ways of opening the file produces differently constructed editors.

Comment 4 Otavio Pontes

2012-10-01 14:40:01 EDT

Please, copy me in gerrit when you send a patch to fix this. I can help you reviewing it.

Comment 5 Sami Wagiaalla

2012-10-02 09:37:44 EDT

It turns out that files opened through File->Open do not go through OpenFileAction and there for do not have PathEditorInput. This change: https://git.eclipse.org/r/#/c/8019/ should fix that and other similar issues.

Comment 6 Sami Wagiaalla

2012-10-02 09:41:06 EDT

*** Bug 385231 has been marked as a duplicate of this bug. ***

Comment 7 Sami Wagiaalla

2012-12-17 14:28:01 EST

Fixed.