Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388479

Summary: NullPointerException in ServletFileStoreHandler.handleRequest
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: ServerAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: antonm
Version: unspecified   
Target Milestone: 1.0 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description John Arthorne CLA 2012-08-30 16:08:31 EDT
I20120829-2230

Anton had a self hosting site running at anton.orion.eclipse.org:8080

Trying to navigate to the root of that site was producing this error:

java.lang.NullPointerException: null
        at org.eclipse.orion.internal.server.servlets.file.ServletFileStoreHandler.handleRequest(ServletFileStoreHandler.java:150) ~[na:na]
        at org.eclipse.orion.internal.server.servlets.file.ServletFileStoreHandler.handleRequest(ServletFileStoreHandler.java:1) ~[na:na]
        at org.eclipse.orion.internal.server.hosting.HostedSiteServlet.serveOrionFile(HostedSiteServlet.java:263) ~[na:na]
        at org.eclipse.orion.internal.server.hosting.HostedSiteServlet.serve(HostedSiteServlet.java:223) ~[na:na]
        at org.eclipse.orion.internal.server.hosting.HostedSiteServlet.service(HostedSiteServlet.java:164) ~[na:na]
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:848) ~[javax.servlet_3.0.0.v201112011016.jar:na]
        at org.eclipse.equinox.http.registry.internal.ServletManager$ServletWrapper.service(ServletManager.java:180) ~[na:na]
        at org.eclipse.equinox.http.servlet.internal.ServletRegistration.service(ServletRegistration.java:61) ~[na:na]
        at org.eclipse.equinox.http.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:38) ~[na:na]
        at org.eclipse.orion.internal.server.hosting.HostedSiteRequestFilter.doFilter(HostedSiteRequestFilter.java:50) ~[na:na]
        at org.eclipse.equinox.http.registry.internal.FilterManager$FilterWrapper.doFilter(FilterManager.java:173) ~[na:na]
Comment 1 John Arthorne CLA 2012-08-30 16:43:38 EDT
What happens here is an expected 404 because the file path does not exist. Due to the URL refactoring the existing site had a mapping to a path that no longer exists. However there was a bug in the exception handling on the server causing an NPE and finally a 500 server error. I have fixed that so the 404 error will show through.

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=63e5726aef196c2771a261b9c83bfa9f5de5939d