Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388457

Summary:	Disable original jsContentAssist plugin
Product:	[ECD] Orion	Reporter:	Andrew Eisenberg <andrew.eisenberg>
Component:	Editor	Assignee:	Project Inbox <orion.editor-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne
Version:	unspecified
Target Milestone:	1.0 M2
Hardware:	All
OS:	All
Whiteboard:

Description Andrew Eisenberg

2012-08-30 12:32:42 EDT

Now that the esprima-based content assist plugin is available in orion, we should disable the original jsContentAssist plugin so that duplicates do not exist.

More specifically, we should disable the pieces that are duplicated and keep the other parts.  Here is what I propose to do:

1. delete the parts of the plugin that generate member, parameter, and variable completions.
2. retain the parts of the plugin that generate templates and keywords
3. change the name from jsContentAssist to jsTemplatesContentAssist to be more reflective of what it is doing.
4. update the content assist tests so they don't fail

Question: is there any reason to keep the old content assist plugin around?

Comment 1 Andrew Eisenberg

2012-08-31 00:15:14 EDT

This work is now pushed to master branch:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5725b03a14290c62181dd6cf1f11d31bc476bc04