Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388384

Summary: Initial commit of the Esprima content assist plugin
Product: [ECD] Orion Reporter: Andrew Eisenberg <andrew.eisenberg>
Component: EditorAssignee: Project Inbox <orion.editor-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3    
Version: unspecified   
Target Milestone: 1.0 M2   
Hardware: All   
OS: All   
Whiteboard:

Description Andrew Eisenberg CLA 2012-08-29 17:32:07 EDT
I just pushed all of the files needed for esprima-based content assist
into master.  This is a large commit, so I just want everyone to be
aware of what has gone in and how things will be affected.

Here's what I committed:

1. the esprima parser in esprima.js (actually, Andy Clement committed
this a few days ago)
2. the logic for content assist itself in the esprimaJsContentAssist.js file
3. extra js files for indexing, navigation, and module name
verification.  This functionality is currently disabled since it
requires some server components which are not yet available
4. a stub for the doctrine library to parse jsdoc comments.  The
doctrine library is currently going through the CQ process and when it
is approved, I'll replace the stub with the actual library.
5. unit tests for all of this in the js-tests folder
6. a new entry in the defaults.pref file to automatically install the
esprima-based content assistant

Things are holding together for me and all of the tests are passing,
but please add a comment here if anything odd is happening for you and I will
fix it as best as I can.  Once we are happy with this commit, I will
disable the old js content assist (except for the templates and
keyword completions) so there is no more conflicts.

This new version of the plugin comes with quite a few improvements
over what was available before.  I'll write something up soon.

IMPORTANT- If you already have the esprima content assistant from
github installed, then you will need to uninstall it, otherwise there
will be conflicts.

Use this bug report to document any problems that you see.

Here is a link to the git commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=06062cb59cb53d0fb09aff2a75627d7bb1e8307a
Comment 1 Andrew Eisenberg CLA 2012-10-04 15:46:42 EDT
Resolving this bug since the initial commit is now in.  Also, raised bug 391155 to deal with the Doctrine contribution.
Comment 2 John Arthorne CLA 2012-10-09 17:25:56 EDT
Should have been marked fixed.