Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 388268

Summary: cannot handle branch with slash in the name
Product: [ECD] Orion Reporter: John Arthorne <john.arthorne>
Component: GitAssignee: Szymon Brandys <Szymon.Brandys>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Szymon.Brandys
Version: unspecified   
Target Milestone: 2.0 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 386502    

Description John Arthorne CLA 2012-08-28 15:54:26 EDT
Bug 347943 was intended to enable creating branches with a slash in the branch name (e.g., johna/bug343264). However this isn't working. When I try to checkout origin/johna/bug343264 it tells me the current branch is just "bug343264". The repositories page thinks that I have outgoing commits immediately after checkout, and fetch is also broken.

This needs to be completed because branches of the form <userId>/<topic> are a common convention.
Comment 1 Szymon Brandys CLA 2012-08-30 09:01:34 EDT
Hmm. I also thought it was fixed already. For now I can set target 1.0 to not forget about it.
Comment 2 John Arthorne CLA 2012-10-11 11:48:47 EDT
I hit this again today when I accidentally created a branch with a /. It is definitely not encoding the slash properly in all cases. This is what happened when I tried to push such a branch to remote:

POST http://localhost:8080/gitapi/remote/origin/johna/bug389758/file/A/Orion%20Server/

405 (HTTP method GET is not supported by this URL)

I guess at this point it will be a 2.0 fix.
Comment 3 Szymon Brandys CLA 2013-02-04 09:14:59 EST
There are many places where ref names are not encoded. Moreover some POST/PUT methods do not handle encoded refs in urls at all. I will make sure that at least basic ops work in 2.0 ie push, fetch, merge, pull.
Comment 4 Szymon Brandys CLA 2013-02-05 09:04:31 EST
Fixes pushed do client and server. Branches with slashes should be ok now.