Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 387642

Summary:	[18n] Need to move "root" definitions into top file
Product:	[ECD] Orion	Reporter:	Simon Kaegi <simon_kaegi>
Component:	Client	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	malgorzata.tomczyk, Szymon.Brandys
Version:	1.0
Target Milestone:	2.0 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Simon Kaegi

2012-08-20 16:00:07 EDT

I was doing some testing with a consumer using Dojo 1.7 and we found that our i18n support does not currently work in the same way that dojo/i18n works. dojo/i18n requires that there is a root set of definition provided instead of just root:true. To help our dojo consumers we should merge our root definitions into the top messages file.

Comment 1 Simon Kaegi

2012-08-23 14:58:55 EDT

Gosia suggested an elegant solution -- http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a1c2eac478eab725beb0f740ef4760809f6c03f9

I like it!

Comment 2 Szymon Brandys

2012-08-24 03:37:31 EDT

When I looked at the issue, the fix looked obvious to me. Thanks Gosia for turning the idea into the code,
but I see that you Simon fixed it by just replacing root: true with root: { keys }, see commit 30973ddecde1c5b72e5f4e1b2f2e1f52abc2dce4

So I guess we are going my way ie commit a1c2eac478eab725beb0f740ef4760809f6c03f9.

Comment 3 Malgorzata Janczarska

2013-02-04 05:44:58 EST

Fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1a78873f3badd062a44d6458e08e0e55a20a6ada