Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 387638

Summary: parity for eclipse-test and java-test
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: Platform-Releng-Inbox <platform-releng-inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, markus.kell.r
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 374441, 454921    

Description David Williams CLA 2012-08-20 15:04:19 EDT
As noted in bug 381896, there are some differences in our test framework if launching from java, or using the eclipse executable (e.g. 'timeout' is not passed in later case, for one difference). 

There could be others. 

We don't currently use eclipse-test in our own unit testing, but should some day fix things up so they get same arguments passed.
Comment 1 David Williams CLA 2012-08-27 21:24:50 EDT
I've recently noticed this interesting, commented out section, of our main test.xml (that drives all the tests). As far as I can see (though file history is till impossible for me to follow with git) it has been this way for a long time. Any one know/remember why? 


<!--alwasy use eclipse executable to launch tests with the exception of performance tests-->
<!--condition property="useEclipseExe" value="true">
	<not>
	<equals arg1="${test.target}" arg2="performance"/>
	</not>
</condition-->
Comment 2 Dani Megert CLA 2012-08-28 03:24:33 EDT
(In reply to comment #1)
> I've recently noticed this interesting, commented out section, of our main
> test.xml (that drives all the tests). As far as I can see (though file
> history is till impossible for me to follow with git) it has been this way
> for a long time. Any one know/remember why? 

What's the full path / location of that test.xml?
Comment 3 Markus Keller CLA 2012-08-28 07:13:05 EDT
Now, it's /org.eclipse.releng/configuration/eclipseBuilderOverlays/eclipse/buildConfigs/sdk.tests/testScripts/test.xml

But the interesting history is here:
/org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk.tests/testScripts/test.xml

To see the history with EGit (always use nightly builds):
- set History view to Filter > All Changes of Resource
- right-click a commit before the content was deleted and choose Show Annotations
- scroll to the interesting line 682 and click the revision in the change ruler (on the left of the editor)
=> this makes the History view jump to that commit (90ac4f1f56331d5d03db70ffd1509401e8a73828)
=> that commented task was part of a massive change in 2007 and was added there in commented form. I don't think archeology will reveal more insight here.

In case you would have wanted to go further into the past, you would do this:
- in the bottom-left pane of the History view, click the Parent: <sha-1> link
=> this selects the parent commit in the table (which can be far away if you have all branches enabled in the view)
- right-click > Show Annotations again
Comment 4 David Williams CLA 2012-08-28 09:21:38 EDT
Thanks for "how to use EGit" pointers, Markus. I'll give them a try some time. 

But, for this case, I'll try some tests locally and see if the "eclipse exe" approach works at all and if so, I would recommend we switch back to that (after implementing "parity", which I think should be easy) just because I think testing "eclipse exe" is a better test since it tests more similar to the way clients use it. Let me know if you can think of any reasons why that would be a bad idea, or not worth the effort. 

Thanks again,
Comment 5 Dani Megert CLA 2012-08-31 03:20:21 EDT
I neither looked at the history nor checked what it is doing at the moment but from the names I would expect that 'java-test' is used run tests that don't need an Eclipse workbench and can simply be launched via java.exe (like e.g. parser tests). On the other hand 'eclipse-test' is used for all tests that need a workbench. So, 'java-test' would correspond to Run As > JUnit Test and 'eclipse-test' would map to Run As > JUnit Plug-in Test.
Comment 6 Eclipse Genie CLA 2020-02-18 04:53:30 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.