Bugzilla – Full Text Bug Listing
| Summary: | [settings][plugins] - install plugin command binding no longer working | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Ken Walker <ken_walker> |
| Component: | Git | Assignee: | Mark Macdonald <mamacdon> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | antonm, maciej.bendkowski, malgorzata.tomczyk, mamacdon, susan, Szymon.Brandys |
| Version: | 0.5 | ||
| Target Milestone: | 1.0 M2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 389083 | ||
|
Description
Ken Walker
that's probably me with all the layout/life cycle changes in pages. Will investigate. (In reply to comment #1) > that's probably me with all the layout/life cycle changes in pages. Will > investigate. nope. The problem occurs in M1 (orionhub.org) I double checked that other command bindings are still working (navigator ",newFolder=foo" or the install plugins link). So I suspect the lifecycle changed with the changes to how the repo page loads. (In reply to comment #0) > If you chose either the getting started button on the Navigator page or the > greasemonkey script for cloning from Github, the page opens but no input > area for the URL is displayed. Actually it is, but it's immediately treated as invalid or something. Change the hash manually and you will see the URL for a brief moment. I'll investigate this. (In reply to comment #2) > I double checked that other command bindings are still working (navigator > ",newFolder=foo" or the install plugins link). So I suspect the lifecycle > changed with the changes to how the repo page loads. Well, is seems that in the newest version no href bindings are working properly. I've noticed no invocations on the newFolder command nor on the install plugins link. I have no idea what might be the problem. (In reply to comment #4) > (In reply to comment #2) > > I double checked that other command bindings are still working (navigator > > ",newFolder=foo" or the install plugins link). So I suspect the lifecycle > > changed with the changes to how the repo page loads. > > Well, is seems that in the newest version no href bindings are working > properly. I've noticed no invocations on the newFolder command nor on the > install plugins link. I have no idea what might be the problem. on orion.eclipse.org, build I20120816-2230. this URL is working: https://orion.eclipse.org/navigate/table.html#/file/Gm/?depth=1,newFolder=foo the install plugins link like this was working a few days ago: https://orion.eclipse.org/settings/settings.html#,category=plugins but now it is not. I wonder if Anton's changes to remember plugin page have changed the timing. I think this is changes with each page that are causing breakage vs. a universal problem with URL bindings and slideouts. Ok, rechecking again. 1) New folder URL such as: http://orionhub.org/navigate/table.html#/file/hM/?depth=1,newFolder=foo - Works on orionhub and orion.eclipse.org 2) Install plugin URL such as: http://orionhub.org/settings/settings.html#,category=plugins,installPlugin=http://mamacdon.github.com/orion-codemirror/codeMirrorPlugin.html - Works on orionhub but not orion.eclipse.org (working in M1, broken since then) 3) Clone git repository URL such as: http://orion.eclipse.org:8080/git/git-repository.html#,cloneGitRepository=URL - Broken in M1 (orionhub) - Was broken when this bug was filed (see original title) - Now is working I20120904-2230 I think this was probably broken by the late breaking M1 changes for repository page refreshing and has since been fixed. So...the work to do is to fix case (2). Mark is working in here so he is going to look. (thanks) Made the page respect existing URI parameters when updating the 'category' part of the hash. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=688c25c36daf27257a2e91e5b11e093b050e576f |