Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 387307

Summary:

why does textViewContainer have an explicit background color set

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Editor

Assignee:

Project Inbox <orion.editor-inbox>

Status:

RESOLVED WONTFIX

QA Contact:

Severity:

normal

Priority:

CC:

Silenio_Quarti

Version:

0.5

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
screenshot of editor corners	none

Description Susan McCourt

2012-08-15 13:43:53 EDT

While investigating a fix for bug 387223, I was wondering why the editor background ruler always flashes gray before it paints white.  (This was also causing a gray area to appear in the animation delay for the outliner).

It seems that textview.css sets an explicit color for the textview container.
I think we should just remove this completely, thus letting the client style the parent div to be whatever background is appropriate.

This also eliminates the quick flash from gray to white when the annotation rulers appear.

Comment 1 Silenio Quarti

2012-08-15 15:07:44 EDT

Created attachment 219919 [details]
screenshot of editor corners

The main reason is so that the corners of the editor are the same color of the scrollbars when the rulers are not as tall as the editor content. This only matters when the editor horizontal scroll bar is visible (see screenshot).  If the container background was white (not gray), the rulers would look "clipped" at the bottom.

Another reason, the annotation and overview rulers are using that background as well (there are transparent), but that can be changed easily by setting the background of the rulers themselves in rulers.css.

Comment 2 Susan McCourt

2012-08-15 16:13:02 EDT

thanks for the explanation, it's all coming back to me now.  ;-)