Bugzilla – Full Text Bug Listing
| Summary: | Create Review Group error (due to icacls.exe) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Krzysztof Wojtylak <siz632> | ||||
| Component: | Mylyn | Assignee: | Project Inbox <r4e-triaged> | ||||
| Status: | CLOSED MOVED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P5 | CC: | fchouinard, juergen, lmcbout, sebastien.dubois | ||||
| Version: | 0.11.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 399542 | ||||||
| Attachments: |
|
||||||
At the moment R4E supports the following operating systems: Suse Linux 10, x86, x86-64 Windows Vista SP2, x86 Solaris 5.10, sun4u MAC OS X Support for Windows XP is desirable although is not high priority in the short term. The R4E team will be glad to collaborate with a developer willing to drive this contribution. Decreased priority as WindowsXP is fading and this works fine in more recent versions What has a Java user programm to mess with file access permissions? And, there are lots of enterprises who are still in the process of migrating from XP. Why artificially make r4e not work on XP? (In reply to comment #3) > What has a Java user programm to mess with file access permissions? > And, there are lots of enterprises who are still in the process of migrating > from XP. Why artificially make r4e not work on XP? Hi, Actually it was never a deliberate decision to not support WinXP at all. The way R4E works right now, the only back end we support is basically storing the metadata and review content in files that are stored in a filesystem, typically a network drive, but also now on a cloud based storage space e.g. dropbox, google drive etc. The reason why we use file access permission is that when serializing and writing the review data to the drive, we will create new files/directories and we need to make sure that these resources stay writable by all review participants, hence the resource permission change. Actually, there is not much missing to support WinXP, the only thing needed is to identify that we are running on a Win XP OS and add a corresponding value to OSPLATFORM, and subclass the WindowsPermission class to implement the way to set permission on WinXP. Honestly we did not do it before because nobody asked for it and we left it open. Of course, contributions from the community are always welcomed to address this issue. Eventually we will probably migrate the back-end to something more like a server-based backend and this file permission thing will go away. Best Regards, Sebastien Dubois Mylyn Reviews Committer and R4E project lead (In reply to comment #4) > The reason why we use file access permission is that when serializing and > writing the review data to the drive, we will create new files/directories > and we need to make sure that these resources stay writable by all review > participants, hence the resource permission change. An application should never ever change file permissions, instead it should throw an IOException if it cannot write. Then the user can change access modes with explorer or chmod. Permissions are security and no programs should change security settings behind the user's back. If a folder is write protected its owner may have good reasons for it. Different story is a setup.exe, it may change permissions on folders, but this is one of the reasons setups need Admin rights or UAC. (In reply to comment #5) > (In reply to comment #4) > > The reason why we use file access permission is that when serializing and > > writing the review data to the drive, we will create new files/directories > > and we need to make sure that these resources stay writable by all review > > participants, hence the resource permission change. > > An application should never ever change file permissions, instead it should > throw an IOException if it cannot write. Then the user can change access > modes with explorer or chmod. Permissions are security and no programs > should change security settings behind the user's back. If a folder is write > protected its owner may have good reasons for it. > Different story is a setup.exe, it may change permissions on folders, but > this is one of the reasons setups need Admin rights or UAC I agree with you, but there are historical reasons why this is done in R4E, mainly coming from the fact that R4E used to be an internal tool in Ericsson before being open sourced. As for WinXP support, it would be great if that could be done, really the permissions is the only thing that holds it back. We'll have to see if we can remove the permissions code to remove this hindrance. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |
Created attachment 219746 [details] Error log containing described scenarios and eclipse configuration details file. The result of the bug is similar to the #369520, but the reason seems to differ. Issue ocurrs for version 0.11 and also for the newest nightly build version 0.12 (10 AUG 2012). ================================================================================ Steps to reproduce the issue: 1. RMB in Review Navigator -> New Review Group 2. Enter: Group Name: testR4E Group Folder: D:\testR4E Group description: group description 3. Click OK button. The following error encounters: Resource Error Detected Reason: IOException while changing permissions to : D:\testR4E\testR4E_group_root.xrer and in detail section: IOException while changing permissions to : D:\testR4E\testR4E_group_root.xrer The New Review group element does not appear in the Review Nawigator view. -------------------------------------------------------------------------------- Also the following error ocurrs when trying to add the review group incorrectly created in the above steps: 1. Go To: Window->Preferences->R4E. 2. Select the Review Group tab. 3. Click the Add button. 4. From the Open window navigate to D:\testR4E and select the testR4E_group_root.xrer file. 5. Click the Open button. 6. Click the Apply button. The R4E Error window appears with the following message: Some elements failed to load Reason: The following errors were reported: org.eclipse.mylyn.reviews.r4e.core.rfs.spi.ReviewsFileStorageException: java.io.IOException: Cannot run program "icacls": CreateProcess error=2, The system cannot find the file specified ================================================================================ Operating System Details: Microsoft Windows XP Professsional, Version 2002, Service Pack 3 ================================================================================ About Eclipse: Eclipse IDE for C/C++ Developers Version: Juno Release Build id: 20120614-1722 ================================================================================ The error log file attached. Installation Details (configuration) of Eclipse attached. ================================================================================ According to my investigation the "icacls.exe" program does not exist in Win XP. The cacls (or xcacls) commands are to be used instead.