Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386769

Summary: Use of GTK_HAS_FOCUS with deprecated GTK_WIDGET_SET and UNSET FLAGS in Composite Widget
Product: [Eclipse Project] Platform Reporter: Anatoly Spektor <spektor.anatoly>
Component: SWTAssignee: Eric Williams <ericwill>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ericwill, Silenio_Quarti
Version: 4.2Keywords: triaged
Target Milestone: 4.9 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/127431
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e3f3349387b3ce22f47efd31d4fa38e6772723a4
Whiteboard:
Bug Depends on:    
Bug Blocks: 340067    

Description Anatoly Spektor CLA 2012-08-07 13:37:50 EDT 
The discussion regarding this bug started here:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=385315

The function  Composite.setTabItemFocus() uses GTK_WIDGET_SET_FLAGS and GTK_WIDGET_UNSET_FLAGS passing GTK_HAS_FOCUS as a parameter. 

Both function GTK_WIDGET_SET_FLAGS and GTK_WIDGETUNSET_FLAGS are deprecated and should be replaced by "setters". However, there is no suitable setter for HAS_FOCUS in current API.
Comment 1 Eric Williams CLA 2018-04-13 15:24:45 EDT 
A brief inspection of the code shows that this is still the case.
Comment 2 Eclipse Genie CLA 2018-08-14 16:01:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/127431
Comment 4 Eric Williams CLA 2018-08-14 16:41:52 EDT 
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/127431 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=e3f3349387b3ce22f47efd31d4fa38e6772723a4

In master now.
Comment 5 Eric Williams CLA 2018-08-23 08:27:09 EDT 
Verified in I20180821-2000.