Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386596

Summary: Plugin installation broken
Product: [ECD] Orion Reporter: Mark Macdonald <mamacdon>
Component: ClientAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: simon_kaegi
Version: 1.0   
Target Milestone: 1.0 M1   
Hardware: PC   
OS: Windows 7   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=386968
Whiteboard:

Description Mark Macdonald CLA 2012-08-03 15:31:17 EDT 
1. Go to the Settings page, Plugins category
2. Click Install, type in a URL, click Submit
3. Error, and the install fails

Uncaught TypeError: Cannot set property '_expires' of undefined :8080/orion/pluginregistry.js:461
_persist :8080/orion/pluginregistry.js:461
installPlugin :8080/orion/pluginregistry.js:638
dojo.declare.installHandler :8080/orion/widgets/plugin/PluginList.js:198
dojo.declare.startup.mCommands.Command.callback :8080/orion/widgets/plugin/PluginList.js:71
dojo.hitch :8080/org.dojotoolkit/dojo/_base/lang.js:130
CommandParameterCollector._collectAndCall :8080/orion/parameterCollectors.js:159
CommandParameterCollector.getFillFunction.dojo.hitch.finish :8080/orion/parameterCollectors.js:248
CommandParameterCollector.getFillFunction.dojo.hitch.dojo.create.id :8080/orion/parameterCollectors.js:275
dojo.hitch
Comment 1 Mark Macdonald CLA 2012-08-08 11:09:01 EDT 
This is also breaking all the client-side tests that run during builds.
Comment 3 Simon Kaegi CLA 2012-08-09 22:18:34 EDT 
I'm re-opening but moving to M2 as another change is not worth it at the moment.

Sorry all and thanks for the fix Mark. Clearly my bad as I thought this was fixed in my push but I just re-verified and even my local tests are failing. I have the real fix locally in a branch but am gun shy for m1.
Comment 4 Simon Kaegi CLA 2012-08-28 15:38:20 EDT 
This was eventually fixed in M1.