Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386509

Summary:

"Unknown item" in Places list

Product:

[ECD] Orion

Reporter:

John Arthorne <john.arthorne>

Component:

Client

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

malgorzata.tomczyk, susan

Version:

unspecified

Target Milestone:

1.0 M1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Screen shot	none

Description John Arthorne

2012-08-02 12:58:58 EDT

I20120731-2230

I am seeing the following list in the "Places" section in the Navigator page sidebar:

 - Unknown item
 - HTML5 Local File contents

Clicking on "Unknown item" takes me to my folders on orion.eclipse.org.

Comment 1 John Arthorne

2012-08-02 12:59:46 EDT

Created attachment 219494 [details]
Screen shot

Comment 2 Susan McCourt

2012-08-08 15:16:07 EDT

This appears to have been broken by externalizing the plugin strings.  We assume there is a "name" property on the file service, but since the default file service is externalized, there is only "NameKey".  We probably need some general solution that ensures the name field is filled in once resolved, but I may look for a more surgical fix here...investigating.

Comment 3 Susan McCourt

2012-08-08 17:04:56 EDT

Fixed very surgically/bogusly by simply defining a hard coded "Name" property in the Orion file client plugin in addition to "NameKey" and "nls".  This means that the Places list will not be translated correctly but it will get us through M1.

Something feels wrong here, that service metadata properties are changing names when they get translated.  I think instead we need some convention whereby the ServiceReference looks for a catalog and replaces the property value if there is a translated version of it.  Clients shouldn't have to deal with this.

Opened bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=386890 to discuss.

For now the fix is in
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1a98fafc5fc4ce8ee1dca1865f0a41bc6ce8b53b