Bug 386381

Description Vladimir Piskarev 2012-08-01 08:28:01 EDT

Created attachment 219431 [details]
org.example.menu plug-in

Platform Command and Action Set frameworks can be mixed as suggested e.g. in this thread http://www.eclipse.org/forums/index.php/mv/msg/109158/333620. Basically, the menus and separators used in actionSets can be defined in menuContributions, and then they can be seen from both other menuContributions and from actionSets. For example:

   <extension
         point="org.eclipse.ui.commands">
      <command
            id="org.example.menu.dummyCommand"
            name="Dummy">
      </command>
   </extension>
   <extension
         point="org.eclipse.ui.menus">
      <menuContribution
            locationURI="menu:org.eclipse.ui.main.menu?after=navigate">
         <menu
               id="org.eclipse.search.menu"
               label="Search">
            <separator
                  name="internalDialogGroup">
            </separator>
            <separator
                  name="dialogGroup">
            </separator>
            <separator
                  name="fileSearchContextMenuActionsGroup"
                  visible="true">
            </separator>
            <menu
                  id="textSearchSubMenu"
                  label="Text">
               <separator
                     name="group1">
               </separator>
               <separator
                     name="additions">
               </separator>
               <separator
                     name="group2">
               </separator>
            </menu>
            <separator
                  name="contextMenuActionsGroup"
                  visible="true">
            </separator>
            <separator
                  name="occurencesActionsGroup"
                  visible="true">
            </separator>
            <separator
                  name="extraSearchGroup"
                  visible="true">
            </separator>
            <visibleWhen>
               <with
                     variable="activeContexts">
                  <iterate
                        ifEmpty="false"
                        operator="or">
                     <equals
                           value="org.eclipse.search.searchActionSet">
                     </equals>
                  </iterate>
               </with>
            </visibleWhen>
         </menu>
      </menuContribution>
   </extension>
   <extension
         point="org.eclipse.ui.menus">
      <menuContribution
            locationURI="menu:org.eclipse.search.menu">
         <command
               commandId="org.example.menu.dummyCommand"
               style="push">
         </command>
      </menuContribution>
   </extension>

This approach works well in Eclipse 3.8, but can lead to duplicating menus in 4.2. Using the example above, there will be two top-level Search menus alongside: the first Search menu will contain the Dummy command (only), while the second will have all the usual Search contributions. In addition, when started with a new workspace, the second Search menu will have no separators. Please use the attached org.example.menu plug-in to reproduce the issue.