Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386313

Summary: Switching tabs (opened editors) when manifest.mf editor is opened bcomes slow
Product: [Eclipse Project] Platform Reporter: Fabio Zadrozny <fabiofz>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: emoffatt, Lars.Vogel, nobody, pwebster
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Snapshot of profile session in yourkit
none
Profile results done inside yourkit.
none
Yourkit profile results none

Description Fabio Zadrozny CLA 2012-07-31 08:39:20 EDT
Created attachment 219363 [details]
Snapshot of profile session in yourkit

It seems that when I open many editors and try to change tabs, things become pretty slow.

I can reproduce this if I open 20 editors for plugins and JDT (10 for MANIFEST.MF and 10 for .java files) so that (in my screen), at least 10 remain hidden in the stack and then just switching editors (only java or only in the manifest.mf) things become slow.

So, I tracked down what was happening in a yourkit profile session and I'm attaching the results (i.e.: zipped profile results which may be opened in the YourKit profiler and a snapshot I had here while taking a look at the results)

They were gotten after working for some time with Eclipse 4.2 (and at that point I had 12 editors opened). If I just open the editors and change the current editor, the profile is very different from that one. It seems that the layout engine got lost while updating the layout.
Comment 1 Fabio Zadrozny CLA 2012-07-31 08:46:50 EDT
Created attachment 219366 [details]
Profile results done inside yourkit.
Comment 2 Nobody - feel free to take it CLA 2012-08-01 05:33:59 EDT
The zip you mention is not available. Would be nice to have it to investigate the problem.
Comment 3 Fabio Zadrozny CLA 2012-08-01 07:19:10 EDT
Created attachment 219421 [details]
Yourkit profile results
Comment 4 Fabio Zadrozny CLA 2012-08-01 07:19:52 EDT
Just added it again (it seems the upload failed the other time).
Comment 5 Eric Moffatt CLA 2012-08-02 16:10:39 EDT
Sopot, I just tried this on my XP box (10 manifests + 10 Java files) and don't a marked difference in switching...I'll try again on my windows 7 box at home.
Comment 6 Nobody - feel free to take it CLA 2012-08-02 16:18:18 EDT
You still use XP at work ?!?! :)

There have been reports of this kind of switching delay in the forum also http://www.eclipse.org/forums/index.php/t/367243/

I investigated if it had something to do with the switching of toolbar and menu items (witch btw resulted in bug 386301 and 386070 which need your attention) and didn't come up with anything specific.

ASAIC I will take a look at my yourkit results though.
Comment 7 Eric Moffatt CLA 2012-08-13 16:21:49 EDT
lol, it's usually my habit to develop UI code on the slowest available box (on the presumption that if it's OK here it'll just be better elsewhere...;-).

I'm not sure what's going on really. For most of the time I don't see a noticeable lag opening / closing either views or editors (it seems a bit sluggish for editors but still under a sec for sure.

I *have* occasionally had the whole UI lock up for a number of seconds (sometimes quite a few) and we're still looking into this. If we can find a scenario that will cause this to happen repeatably we'd for sure be in a better position to work on it.

For those interested we are *very* aware that 4.x is currently slower than 3.x in many places and have some idea as to why...we intend to do specific work on this in the 4.2.2 cycle so identifying currently 'broken' scenarios will give us something concrete to aim to fix...
Comment 8 Lars Vogel CLA 2016-03-24 04:41:20 EDT
Fabio, can you provide a Gerrit review to improve the performance?
Comment 9 Fabio Zadrozny CLA 2016-03-24 05:37:34 EDT
This can be closed already (in Eclipse 4.5 I no longer have this issue).