Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386162

Summary:	Problems with Chinese input in the editor
Product:	[ECD] Orion	Reporter:	Mihai Sucan <mihai.sucan>
Component:	Editor	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ken_walker, mihai.sucan, simon_kaegi
Version:	unspecified
Target Milestone:	1.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mihai Sucan

2012-07-27 14:59:25 EDT

Users are reporting they have a hard time to write in Chinese with Orion.

Please see:

https://bugzilla.mozilla.org/show_bug.cgi?id=772073

Based on the regression window it seems that bug 630810 might have caused this.

Further investigation is needed.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=630810

Comment 1 Ken Walker

2012-08-08 17:32:48 EDT

Any change to this for M1 Silenio?  Or move to M2

Comment 2 Silenio Quarti

2012-08-16 17:41:31 EDT

Works fine with Firefox 14.

Fails with 17.0a1 (2012-08-16).

The problem started happening because Firefox is sending a keydown event with keycode set to 0 instead of 229 when the input method starts the composition.

Mihai, do you know if this change was intentional? It seems quite bad to get a keydown event with keycode=0. Could this be fixed in mozilla?

Comment 3 Mihai Sucan

2012-08-17 07:12:10 EDT

Silenio, thank you for looking into this issue. Unfortunately, I am not familiar with the changes in Mozilla bug 630810. Please investigate and if you believe this is a bug, a regression on Mozilla's side, please file a bug report in our Bugzilla instance with a minimal test case - this will help us figure out the problem. Also, please CC me in any bug you report. Thanks!

Comment 4 Silenio Quarti

2012-08-17 11:38:42 EDT

We already have different strategies to determine if the ime composition started on Firefox. On windows, we were relying on the keyevent with keycode=229. On all other platforms, we detect that the DOM has been modified by the user agent.  I have changed the code so that we use the same strategy on all platforms.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=512e3c3a589753544ecab2c27fc056741a9396ab

I do not know whether the changes for Mozilla bug 630810 introduced a bug or not, but since it was already inconsistent between platforms, we should not rely on that behavior.

Comment 5 Mihai Sucan

2012-08-17 11:48:23 EDT

Thanks!