Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 386054

Summary: Unnecessary code in dialogs?
Product: [Eclipse Project] Platform Reporter: Carolyn MacLeod <carolynmacleod4>
Component: SWTAssignee: Eric Williams <ericwill>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: arunkumar.thondapu, ericwill, Silenio_Quarti
Version: 4.2Keywords: triaged
Target Milestone: 4.9 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/127433
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=f241cc874342ce675ac143bbdd287a607962252e
Whiteboard:

Description Carolyn MacLeod CLA 2012-07-26 10:44:21 EDT 
It is possible that the code that propagates the icon from the shell to a dialog child may not be needed. The gtk doc for gtk_window_set_icon_list ()
http://developer.gnome.org/gtk/2.24/GtkWindow.html#gtk-window-set-icon-list
says that "transient windows will inherit their icon from their transient parent". So for example this code in MessageBox.open():

if (parentHandle != 0) {
	int /*long*/ pixbufs = OS.gtk_window_get_icon_list (parentHandle);
	if (pixbufs != 0) {
		OS.gtk_window_set_icon_list (handle, pixbufs);
		OS.g_list_free (pixbufs);
	}
}

might not be needed (need to test this to verify). (SSQ thinks it might have been needed in some previous version of GTK, so we would still have to do it before the current version of gtk).
Comment 1 Eclipse Genie CLA 2018-08-14 16:58:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/127433
Comment 3 Eric Williams CLA 2018-08-15 14:57:05 EDT 
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/127433 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=f241cc874342ce675ac143bbdd287a607962252e

In master now.
Comment 4 Eric Williams CLA 2018-08-23 08:27:02 EDT 
Verified in I20180821-2000.