Bug 386028

Description Martin Hanzalek 2012-07-26 07:35:58 EDT

Build Identifier: Version: Indigo Service Release 2 Build id: 20120216-1857

Inline operation on boolean expression 'a || b' doesn't put parenthesis around, so it can result in wrong code. Example:

		boolean a = true;
		boolean b = true;
		boolean c = false;
		boolean a_or_b = a || b;

		// should resolve to false, but after inline operation on 'a_or_b' variable resolves to true
		if (a_or_b && c)
			System.out.println("Error");
		else
			System.out.println("OK");

After inlining a_or_b produces code:

		if (a || b && c)
			System.out.println("Error");
		else
			System.out.println("OK");

instead of ((a || b) && c), which is wrong.

This can lead to a wrong code when you trust refactoring tools and do not check the result.

Reproducible: Always

Steps to Reproduce:
1. Run code:

public class Main {
	public static void main(String[] args) {
		boolean a = true;
		boolean b = true;
		boolean c = false;
		boolean a_or_b = a || b;

		// should resolve to false, but after inline operation on 'a_or_b' variable resolves to true
		if (a_or_b && c)
			System.out.println("Error");
		else
			System.out.println("OK");
	}
}
Should print 'OK'.

2. Run inline operation on a_or_b expression

3. run code again, prints 'Error'.